From: Otto Moerbeek Date: Mon, 25 Mar 2024 08:21:49 +0000 (+0100) Subject: Apply suggestions from code review: typos in comments X-Git-Tag: rec-5.1.0-alpha1~82^2~5 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=62f1e7728c1074e9dc51fa313baccc93ed209041;p=thirdparty%2Fpdns.git Apply suggestions from code review: typos in comments Co-authored-by: Fred Morcos --- diff --git a/pdns/recursordist/rec-main.cc b/pdns/recursordist/rec-main.cc index 1013c48207..3de3e1eb37 100644 --- a/pdns/recursordist/rec-main.cc +++ b/pdns/recursordist/rec-main.cc @@ -3202,7 +3202,7 @@ int main(int argc, char** argv) handleRuntimeDefaults(startupLog); if (auto ttl = ::arg().asNum("system-resolver-ttl"); ttl != 0) { - // Cannot use SyncRes::s_serverID, it is nt set yet + // Cannot use SyncRes::s_serverID, it is not set yet pdns::RecResolve::setInstanceParameters(arg()["server-id"], ttl, []() { reloadZoneConfiguration(g_yamlSettings); }); } diff --git a/pdns/recursordist/rec-system-resolve.cc b/pdns/recursordist/rec-system-resolve.cc index 5383be9704..65fde36f55 100644 --- a/pdns/recursordist/rec-system-resolve.cc +++ b/pdns/recursordist/rec-system-resolve.cc @@ -92,6 +92,7 @@ std::string serverID() } } // anonymous namespace +// RecResolve class members. std::string pdns::RecResolve::s_serverID; time_t pdns::RecResolve::s_ttl{0}; std::function pdns::RecResolve::s_callback; diff --git a/pdns/recursordist/settings/rust/Cargo.toml b/pdns/recursordist/settings/rust/Cargo.toml index b635af385c..c14e85d6e0 100644 --- a/pdns/recursordist/settings/rust/Cargo.toml +++ b/pdns/recursordist/settings/rust/Cargo.toml @@ -13,7 +13,7 @@ serde = { version = "1.0", features = ["derive"] } serde_yaml = "0.9" ipnet = "2.8" once_cell = "1.18.0" -hostname-validator = "1.1.1" # This is temporary. PR 13819 has the infra to call C++ from, so we can arrange for DNSName::ishostname() to be called instead of importing another crate aftyer that one is merged. +hostname-validator = "1.1.1" # This is temporary. PR 13819 has the infra to call C++ from, so we can arrange for DNSName::ishostname() to be called instead of importing another crate after that one is merged. [build-dependencies] cxx-build = "1.0"