From: lpsolit%gmail.com <>
Date: Wed, 13 Jul 2005 05:38:55 +0000 (+0000)
Subject: Bug 300379: GenerateVersionTable's rename may fail silently - Patch by byron jones... 
X-Git-Tag: bugzilla-2.20rc2~42
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6314e66523a154cb870a1d96b3c24a3a600a04ab;p=thirdparty%2Fbugzilla.git

Bug 300379: GenerateVersionTable's rename may fail silently - Patch by byron jones (glob) <bugzilla@glob.com.au> r=LpSolit a=justdave
---

diff --git a/globals.pl b/globals.pl
index 517ed1827c..bc9aa99ef7 100644
--- a/globals.pl
+++ b/globals.pl
@@ -310,7 +310,8 @@ sub GenerateVersionTable {
     print $fh "1;\n";
     close $fh;
 
-    rename $tmpname, "$datadir/versioncache" || die "Can't rename $tmpname to versioncache";
+    rename ($tmpname, "$datadir/versioncache")
+        || die "Can't rename $tmpname to versioncache";
     ChmodDataFile("$datadir/versioncache", 0666);
 }