From: Pavel Hrdina <phrdina@redhat.com>
Date: Wed, 10 Mar 2021 10:47:24 +0000 (+0100)
Subject: conf: use switch in virDomainDefParseBootOptions
X-Git-Tag: v7.2.0-rc1~75
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6330be1ba3af5c4d2150fe2b831f7bc5d87c6d2a;p=thirdparty%2Flibvirt.git

conf: use switch in virDomainDefParseBootOptions

The original code used a lot of conditions and was not that obvious
when each XML bits are parsed.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 226a68eb14..c1fcab8507 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -19684,33 +19684,43 @@ virDomainDefParseBootOptions(virDomainDefPtr def,
      *   - An init script                             (exe)
      */
 
-    if (def->os.type == VIR_DOMAIN_OSTYPE_EXE) {
-        if (virDomainDefParseBootInitOptions(def, ctxt) < 0)
-            return -1;
-    }
-
-    if (def->os.type == VIR_DOMAIN_OSTYPE_XEN ||
-        def->os.type == VIR_DOMAIN_OSTYPE_XENPVH ||
-        def->os.type == VIR_DOMAIN_OSTYPE_HVM ||
-        def->os.type == VIR_DOMAIN_OSTYPE_UML) {
-
+    switch ((virDomainOSType) def->os.type) {
+    case VIR_DOMAIN_OSTYPE_HVM:
         virDomainDefParseBootKernelOptions(def, ctxt);
 
-        if (def->os.type == VIR_DOMAIN_OSTYPE_HVM) {
-            if (virDomainDefParseBootFirmwareOptions(def, ctxt) < 0)
-                return -1;
-        }
+        if (virDomainDefParseBootFirmwareOptions(def, ctxt) < 0)
+            return -1;
 
         if (virDomainDefParseBootLoaderOptions(def, ctxt) < 0)
             return -1;
-    }
 
-    if (def->os.type == VIR_DOMAIN_OSTYPE_HVM) {
         if (virDomainDefParseBootAcpiOptions(def, ctxt) < 0)
             return -1;
 
         if (virDomainDefParseBootXML(ctxt, def) < 0)
             return -1;
+
+        break;
+
+    case VIR_DOMAIN_OSTYPE_XEN:
+    case VIR_DOMAIN_OSTYPE_XENPVH:
+    case VIR_DOMAIN_OSTYPE_UML:
+        virDomainDefParseBootKernelOptions(def, ctxt);
+
+        if (virDomainDefParseBootLoaderOptions(def, ctxt) < 0)
+            return -1;
+
+        break;
+
+    case VIR_DOMAIN_OSTYPE_EXE:
+        if (virDomainDefParseBootInitOptions(def, ctxt) < 0)
+            return -1;
+
+        break;
+
+    case VIR_DOMAIN_OSTYPE_LINUX:
+    case VIR_DOMAIN_OSTYPE_LAST:
+        break;
     }
 
     return 0;