From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Tue, 5 Dec 2023 13:26:14 +0000 (+0100)
Subject: Disabling structured logging is deprecated
X-Git-Tag: auth-4.9.0-alpha1~41^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6362c4df2bac887ba5e3d4e630186f8709b6e3f3;p=thirdparty%2Fpdns.git

Disabling structured logging is deprecated
---

diff --git a/pdns/recursordist/rec-main.cc b/pdns/recursordist/rec-main.cc
index ed853cfbac..cec1d82815 100644
--- a/pdns/recursordist/rec-main.cc
+++ b/pdns/recursordist/rec-main.cc
@@ -3009,6 +3009,9 @@ int main(int argc, char** argv)
     g_log.setLoglevel(s_logUrgency);
     g_log.toConsole(s_logUrgency);
     showProductVersion();
+    if (!g_slogStructured) {
+      g_log << Logger::Warning << "Disabling structured logging is deprecated, old-style logging wil be removed in a future release" << endl;
+    }
 
     g_yamlSettings = false;
     string configname = ::arg()["config-dir"] + "/recursor";
diff --git a/pdns/recursordist/settings/table.py b/pdns/recursordist/settings/table.py
index 75158bc495..c558a6bada 100644
--- a/pdns/recursordist/settings/table.py
+++ b/pdns/recursordist/settings/table.py
@@ -2570,7 +2570,8 @@ A sequence of statistic names, that are prevented from being exported via SNMP,
         'doc' : '''
 Prefer structured logging when both an old style and a structured log messages is available.
  ''',
-    'versionadded': '4.6.0'
+        'versionadded': '4.6.0',
+        'versionchanged': ('5.0.0', 'Disabling structured logging is deprecated'),
     },
     {
         'name' : 'structured_logging_backend',