From: Volker Lendecke <vl@samba.org>
Date: Thu, 14 Mar 2019 15:13:10 +0000 (+0100)
Subject: libcli: Add a comment explaining lack of overflow checks
X-Git-Tag: talloc-2.2.0~55
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=636c09c8132dd48ece6c40d86f3c93e73d8cfc1d;p=thirdparty%2Fsamba.git

libcli: Add a comment explaining lack of overflow checks

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/libcli/named_pipe_auth/npa_tstream.c b/libcli/named_pipe_auth/npa_tstream.c
index 8ec52ed9b85..9ae4acb7f0b 100644
--- a/libcli/named_pipe_auth/npa_tstream.c
+++ b/libcli/named_pipe_auth/npa_tstream.c
@@ -852,6 +852,9 @@ static struct tevent_req *tstream_npa_writev_send(TALLOC_CTX *mem_ctx,
 
 		msg_len = 0;
 		for (i=0; i < count; i++) {
+			/*
+			 * overflow check already done in tstream_writev_send
+			 */
 			msg_len += vector[i].iov_len;
 		}