From: Daniel P. Berrange <berrange@redhat.com>
Date: Tue, 11 Sep 2012 13:44:40 +0000 (+0100)
Subject: Add missing 'goto error' in QEMU command line building
X-Git-Tag: v0.10.2-rc1~62
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=637a1124ae35a51e39c87f0e851b1e8112cb5e26;p=thirdparty%2Flibvirt.git

Add missing 'goto error' in QEMU command line building

If reporting case of a binary not supporting KVM or kQEMU, libvirt
forgot to jump to the error branch for cleanup
---

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index b8c5658f5a..a512e6adab 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -4449,6 +4449,7 @@ qemuBuildCommandLine(virConnectPtr conn,
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                            _("the QEMU binary %s does not support kqemu"),
                            emulator);
+            goto error;
         }
         break;
 
@@ -4462,6 +4463,7 @@ qemuBuildCommandLine(virConnectPtr conn,
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                            _("the QEMU binary %s does not support kvm"),
                            emulator);
+            goto error;
         }
         break;