From: James Jones <jejones3141@gmail.com>
Date: Tue, 23 Aug 2022 15:24:35 +0000 (-0500)
Subject: Remove needless if (#4687)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=637ef1b898dbf3350eebed8738cd2600d992ce81;p=thirdparty%2Ffreeradius-server.git

Remove needless if (#4687)

There's no unused result--the comparison just checks slen, which is
used in the code startng with done:, which is always gone to.
---

diff --git a/src/lib/util/udp.c b/src/lib/util/udp.c
index 48a10c4b7e1..d1cdd958f7e 100644
--- a/src/lib/util/udp.c
+++ b/src/lib/util/udp.c
@@ -172,8 +172,6 @@ ssize_t udp_recv(int sockfd, int flags,
 	 */
 	if ((flags & UDP_FLAGS_CONNECTED) != 0) {
 		slen = recv(sockfd, data, data_len, sock_flags);
-		if (slen <= 0) goto done;
-
 		goto done;
 	}