From: Rico Tzschichholz <ricotz@ubuntu.com>
Date: Wed, 2 Oct 2019 16:19:53 +0000 (+0200)
Subject: codegen: Initialize delegate temp-var which is assigned by property getter
X-Git-Tag: 0.44.9~17
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6392e39353b1c0bccc9beea91ee1df3c241bd5ec;p=thirdparty%2Fvala.git

codegen: Initialize delegate temp-var which is assigned by property getter

Found by -Werror=maybe-uninitialized
---

diff --git a/codegen/valaccodememberaccessmodule.vala b/codegen/valaccodememberaccessmodule.vala
index 1f72c1f0e..8fb01eaa6 100644
--- a/codegen/valaccodememberaccessmodule.vala
+++ b/codegen/valaccodememberaccessmodule.vala
@@ -254,7 +254,8 @@ public abstract class Vala.CCodeMemberAccessModule : CCodeControlFlowModule {
 				}
 
 				bool prop_is_real_non_null_struct_type = prop.property_type.is_real_non_null_struct_type ();
-				var temp_value = (GLibValue) create_temp_value (prop.get_accessor.value_type, prop_is_real_non_null_struct_type, expr);
+				bool requires_init = prop.property_type is DelegateType || prop_is_real_non_null_struct_type;
+				var temp_value = (GLibValue) create_temp_value (prop.get_accessor.value_type, requires_init, expr);
 				expr.target_value = load_temp_value (temp_value);
 				var ctemp = get_cvalue_ (temp_value);