From: David Benjamin <davidben@mit.edu>
Date: Wed, 13 Mar 2013 05:08:01 +0000 (-0400)
Subject: Fix condition with empty body
X-Git-Tag: krb5-1.10.5-final~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=63b5902e83eb7d47f2eb061acde2566ec1d45bc8;p=thirdparty%2Fkrb5.git

Fix condition with empty body

Found by clang's warnings.

(cherry picked from commit 18796a2eb6c05706c6635453b3e425955aab93f4)

ticket: 7606 (new)
version_fixed: 1.10.5
status: resolved
---

diff --git a/src/lib/kdb/keytab.c b/src/lib/kdb/keytab.c
index 00b45f8107..b85b67daac 100644
--- a/src/lib/kdb/keytab.c
+++ b/src/lib/kdb/keytab.c
@@ -41,8 +41,8 @@ static krb5_error_code
 krb5_ktkdb_get_name(krb5_context context, krb5_keytab keytab,
                     char *name, unsigned int namelen)
 {
-    if (strlcpy(name, "KDB:", namelen) >= namelen);
-    return KRB5_KT_NAME_TOOLONG;
+    if (strlcpy(name, "KDB:", namelen) >= namelen)
+        return KRB5_KT_NAME_TOOLONG;
     return 0;
 }