From: Mike Bayer Date: Fri, 25 Mar 2016 23:33:15 +0000 (-0400) Subject: - remember to not reassign self.connection now that __connect() X-Git-Tag: rel_1_1_0b1~88 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=63d2a486bf84f798387bd45db558610b247e0aa5;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git - remember to not reassign self.connection now that __connect() has no return value --- diff --git a/lib/sqlalchemy/pool.py b/lib/sqlalchemy/pool.py index fd1fefd003..4bd8f60ec9 100644 --- a/lib/sqlalchemy/pool.py +++ b/lib/sqlalchemy/pool.py @@ -556,7 +556,7 @@ class _ConnectionRecord(object): recycle = False if self.connection is None: self.info.clear() - self.connection = self.__connect() + self.__connect() elif self.__pool._recycle > -1 and \ time.time() - self.starttime > self.__pool._recycle: self.__pool.logger.info( @@ -582,7 +582,7 @@ class _ConnectionRecord(object): self.__close() self.info.clear() - self.connection = self.__connect() + self.__connect() return self.connection def __close(self):