From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Tue, 2 Feb 2021 21:22:25 +0000 (+0100)
Subject: cgroups: stricter argument vetting for cgroup_attach()
X-Git-Tag: lxc-5.0.0~305^2~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6407e1c244ea62d951a343a35d391ad181d0c7ac;p=thirdparty%2Flxc.git

cgroups: stricter argument vetting for cgroup_attach()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/cgroups/cgfsng.c b/src/lxc/cgroups/cgfsng.c
index 2dce7673b..498c2d819 100644
--- a/src/lxc/cgroups/cgfsng.c
+++ b/src/lxc/cgroups/cgfsng.c
@@ -3465,7 +3465,7 @@ int cgroup_attach(const struct lxc_conf *conf, const char *name,
 	__do_close int unified_fd = -EBADF;
 	int ret;
 
-	if (!conf || !name || !lxcpath || pid <= 0)
+	if (!conf || is_empty_string(name) || !is_empty_string(lxcpath) || pid <= 0)
 		return ret_errno(EINVAL);
 
 	unified_fd = lxc_cmd_get_cgroup2_fd(name, lxcpath);