From: Ján Tomko <jtomko@redhat.com>
Date: Thu, 10 Dec 2020 09:03:42 +0000 (+0100)
Subject: hyperv: remove duplicit addr check
X-Git-Tag: v7.0.0-rc1~226
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=641fd93de163988eca43990a2431a80750eea991;p=thirdparty%2Flibvirt.git

hyperv: remove duplicit addr check

We already check addr is not negative right after filling
its value. There's no need to check it before using it too.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Fixes: a7a1d1f59e8ba2d8a3ed920ef595ccdfb0d8feb6
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index c2c103aa3b..1200bf02ff 100644
--- a/src/hyperv/hyperv_driver.c
+++ b/src/hyperv/hyperv_driver.c
@@ -561,9 +561,6 @@ hypervDomainDefParsePhysicalDisk(hypervPrivate *priv,
     driveNumberStr = g_strdup_printf("%u", diskdrive->data->DriveNumber);
     virDomainDiskSetSource(disk, driveNumberStr);
 
-    if (addr < 0)
-        goto cleanup;
-
     if (controller->data->ResourceType == MSVM_RASD_RESOURCETYPE_PARALLEL_SCSI_HBA) {
         for (i = 0; i < HYPERV_MAX_SCSI_CONTROLLERS; i++) {
             if (controller == scsiControllers[i]) {