From: Rico Tzschichholz <ricotz@ubuntu.com>
Date: Tue, 15 May 2018 06:17:43 +0000 (+0200)
Subject: codegen: Avoid critical in get_basic_type_info() when there is no signature
X-Git-Tag: 0.34.18~11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6420d289234db811dba22498aa8f8af5402ff6be;p=thirdparty%2Fvala.git

codegen: Avoid critical in get_basic_type_info() when there is no signature

https://bugzilla.gnome.org/show_bug.cgi?id=729517
---

diff --git a/codegen/valagvariantmodule.vala b/codegen/valagvariantmodule.vala
index ef29fe97e..5aa9c8fea 100644
--- a/codegen/valagvariantmodule.vala
+++ b/codegen/valagvariantmodule.vala
@@ -61,11 +61,13 @@ public class Vala.GVariantModule : GAsyncModule {
 		return symbol.get_attribute_string ("DBus", "signature");
 	}
 
-	bool get_basic_type_info (string signature, out BasicTypeInfo basic_type) {
-		foreach (BasicTypeInfo info in basic_types) {
-			if (info.signature == signature) {
-				basic_type = info;
-				return true;
+	bool get_basic_type_info (string? signature, out BasicTypeInfo basic_type) {
+		if (signature != null) {
+			foreach (BasicTypeInfo info in basic_types) {
+				if (info.signature == signature) {
+					basic_type = info;
+					return true;
+				}
 			}
 		}
 		basic_type = BasicTypeInfo ();