From: stephen hemminger <stephen@networkplumber.org>
Date: Fri, 27 Sep 2013 00:42:16 +0000 (-0700)
Subject: qdisc: basic classifier - remove unnecessary initialization
X-Git-Tag: v3.13-rc1~105^2~270
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6459082a3cfb2e79a93ffcbfae3b5924ec9cac77;p=thirdparty%2Fkernel%2Fstable.git

qdisc: basic classifier - remove unnecessary initialization

err is set once, then first code resets it.
  err = tcf_exts_validate(...)

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Jamal Hadi Salim <hadi@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/sched/cls_basic.c b/net/sched/cls_basic.c
index d76a35d0dc85b..636d9131d8701 100644
--- a/net/sched/cls_basic.c
+++ b/net/sched/cls_basic.c
@@ -137,7 +137,7 @@ static int basic_set_parms(struct net *net, struct tcf_proto *tp,
 			   struct nlattr **tb,
 			   struct nlattr *est)
 {
-	int err = -EINVAL;
+	int err;
 	struct tcf_exts e;
 	struct tcf_ematch_tree t;