From: Adhemerval Zanella Date: Fri, 17 Oct 2025 19:12:36 +0000 (-0300) Subject: stdlib: Remove -Wmaybe-uninitialized supression on setenv.c X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=64a0f4b77621a679bae711ec61a7595dcc924a87;p=thirdparty%2Fglibc.git stdlib: Remove -Wmaybe-uninitialized supression on setenv.c It is not required on current supported gcc. Reviewed-by: Florian Weimer --- diff --git a/stdlib/setenv.c b/stdlib/setenv.c index 0ef5dde373..2b8b6cafa0 100644 --- a/stdlib/setenv.c +++ b/stdlib/setenv.c @@ -21,14 +21,6 @@ #include #include - -/* Pacify GCC; see the commentary about VALLEN below. This is needed - at least through GCC 4.9.2. Pacify GCC for the entire file, as - there seems to be no way to pacify GCC selectively, only for the - place where it's needed. Do not use DIAG_IGNORE_NEEDS_COMMENT - here, as it's not defined yet. */ -#pragma GCC diagnostic ignored "-Wmaybe-uninitialized" - #include #if !_LIBC # if !defined errno && !defined HAVE_ERRNO_DECL @@ -147,10 +139,8 @@ __add_to_environ (const char *name, const char *value, const char *combined, { /* Compute lengths before locking, so that the critical section is less of a performance bottleneck. VALLEN is needed only if - COMBINED is null (unfortunately GCC is not smart enough to deduce - this; see the #pragma at the start of this file). Testing - COMBINED instead of VALUE causes setenv (..., NULL, ...) to dump - core now instead of corrupting memory later. */ + COMBINED is null. Testing COMBINED instead of VALUE causes setenv + (..., NULL, ...) to dump core now instead of corrupting memory later. */ const size_t namelen = strlen (name); size_t vallen; if (combined == NULL)