From: Alan T. DeKok <aland@freeradius.org>
Date: Fri, 4 Nov 2016 12:38:35 +0000 (-0400)
Subject: more error messages
X-Git-Tag: release_3_0_13~122
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=64adbce374335dfab677295e955221b892cf3bc3;p=thirdparty%2Ffreeradius-server.git

more error messages
---

diff --git a/src/modules/rlm_perl/rlm_perl.c b/src/modules/rlm_perl/rlm_perl.c
index 73db48a7659..5ec63cb9c1a 100644
--- a/src/modules/rlm_perl/rlm_perl.c
+++ b/src/modules/rlm_perl/rlm_perl.c
@@ -701,14 +701,20 @@ static void pairadd_sv(TALLOC_CTX *ctx, REQUEST *request, VALUE_PAIR **vps, char
 	STRLEN len;
 
 	if (!SvOK(sv)) {
-	fail:
-		REDEBUG("Failed to create pair &%s:%s %s $%s{'%s'} -> '%s'", list_name, key,
+		REDEBUG("Internal failure creating pair &%s:%s %s $%s{'%s'} -> '%s'", list_name, key,
 			fr_int2str(fr_tokens, op, "<INVALID>"), hash_name, key, (val ? val : "undef"));
 		return;
 	}
+
 	val = SvPV(sv, len);
 	vp = fr_pair_make(ctx, vps, key, NULL, op);
-	if (!vp) goto fail;
+	if (!vp) {
+	fail:
+		REDEBUG("Failed to create pair - %s", fr_strerror());
+		REDEBUG("    &%s:%s %s $%s{'%s'} -> '%s'", list_name, key,
+			fr_int2str(fr_tokens, op, "<INVALID>"), hash_name, key, (val ? val : "undef"));
+		return;
+	}
 
 	switch (vp->da->type) {
 	case PW_TYPE_STRING: