From: Jiri Denemark <jdenemar@redhat.com>
Date: Thu, 22 Feb 2018 12:24:58 +0000 (+0100)
Subject: qemu_hotplug: Drop dead code in net update
X-Git-Tag: v4.1.0-rc1~22
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=64ba7803ca1dc04aa5cbc60b4cf51c1868ae0dc4;p=thirdparty%2Flibvirt.git

qemu_hotplug: Drop dead code in net update

vm->def->nets[changeidx] can never be NULL for changeidx returned by
virDomainNetFindIdx.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 87cf578acc..e0a5300f08 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -3061,12 +3061,7 @@ qemuDomainChangeNet(virQEMUDriverPtr driver,
     if ((changeidx = virDomainNetFindIdx(vm->def, newdev)) < 0)
         goto cleanup;
     devslot = &vm->def->nets[changeidx];
-
-    if (!(olddev = *devslot)) {
-        virReportError(VIR_ERR_OPERATION_FAILED, "%s",
-                       _("cannot find existing network device to modify"));
-        goto cleanup;
-    }
+    olddev = *devslot;
 
     oldType = virDomainNetGetActualType(olddev);
     if (oldType == VIR_DOMAIN_NET_TYPE_HOSTDEV) {