From: H.J. Lu <hjl.tools@gmail.com>
Date: Wed, 15 Jan 2025 10:11:47 +0000 (+0800)
Subject: ld: Correct ldelf_place_orphan
X-Git-Tag: binutils-2_44~120
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=64e281da5f2f466f51bebffc2e16d6f608d8d9e0;p=thirdparty%2Fbinutils-gdb.git

ld: Correct ldelf_place_orphan

Remove the extra for loop and if statement in ldelf_place_orphan.

	* ldelf.c (ldelf_place_orphan): Remove the extra for loop and if
	statement.

Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
---

diff --git a/ld/ldelf.c b/ld/ldelf.c
index a66d1d21394..dfe8032f255 100644
--- a/ld/ldelf.c
+++ b/ld/ldelf.c
@@ -2275,19 +2275,17 @@ ldelf_place_orphan (asection *s, const char *secname, int constraint)
     {
       struct orphan_save *ho, *horig;
 
-      for (ho = hold; ho < hold + sizeof (hold) / sizeof (hold[0]); ++ho)
       for (ho = hold, horig = orig_hold;
 	   ho < hold + ARRAY_SIZE (hold);
 	   ++ho, ++horig)
 	{
 	  *ho = *horig;
 	  if (ho->name != NULL)
-	if (ho->name != NULL)
-	  {
-	    ho->os = lang_output_section_find (ho->name);
-	    if (ho->os != NULL && ho->os->flags == 0)
-	      ho->os->flags = ho->flags;
-	  }
+	    {
+	      ho->os = lang_output_section_find (ho->name);
+	      if (ho->os != NULL && ho->os->flags == 0)
+		ho->os->flags = ho->flags;
+	    }
 	}
       orphan_init_done = true;
     }