From: Thomas Markwalder <tmark@isc.org>
Date: Thu, 23 Mar 2023 11:12:39 +0000 (-0400)
Subject: [#2719] Addressed remaining comments
X-Git-Tag: Kea-2.3.6~45
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=650775171f1acda1450c4011139fcb6e1e75d24b;p=thirdparty%2Fkea.git

[#2719] Addressed remaining comments

modified:
    doc/examples/kea4/all-keys.json
    src/lib/dhcpsrv/tests/alloc_engine4_unittest.cc
---

diff --git a/doc/examples/kea4/all-keys.json b/doc/examples/kea4/all-keys.json
index 075b54d301..86f5038659 100644
--- a/doc/examples/kea4/all-keys.json
+++ b/doc/examples/kea4/all-keys.json
@@ -58,7 +58,11 @@
                 "min-valid-lifetime": 4000,
 
                 // Class max valid lifetime.
-                "max-valid-lifetime": 8000
+                "max-valid-lifetime": 8000,
+
+                // If greater than zero, it is the lifetime of leases temporarily allocated
+                // on DISCOVER.  When zero (the default) leases are not allocated on DISCOVER.
+                "offer-lifetime" : 65
             },
             {
                 // Default value of the class specific bootfile name. Empty name
diff --git a/src/lib/dhcpsrv/tests/alloc_engine4_unittest.cc b/src/lib/dhcpsrv/tests/alloc_engine4_unittest.cc
index 337065425c..942944b2d7 100644
--- a/src/lib/dhcpsrv/tests/alloc_engine4_unittest.cc
+++ b/src/lib/dhcpsrv/tests/alloc_engine4_unittest.cc
@@ -5945,7 +5945,7 @@ TEST_F(AllocEngine4Test, getOfferLft4) {
             exp_allocate
         },
         {
-            // Useing class value of zero should override non-zero set at
+            // Using class value of zero should override non-zero set at
             // subnet level, lease should have actual valid lft
             "zero from class",
             { "offer_lft_zero" },