From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 13 Apr 2021 14:17:24 +0000 (+0200)
Subject: qemuMigrationSrcNBDStorageCopy: Return error code on error
X-Git-Tag: v7.3.0-rc1~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=652ea8083b6a3bd6e559649ec8501a58e691bf20;p=thirdparty%2Flibvirt.git

qemuMigrationSrcNBDStorageCopy: Return error code on error

In case the 'nbdURI' schema is not known the code would report an error
but wouldn't return failure.

Fixes: 49186372dbe
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Tested-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index df88f954ed..1c3e599128 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -1154,6 +1154,7 @@ qemuMigrationSrcNBDStorageCopy(virQEMUDriver *driver,
             virReportError(VIR_ERR_INVALID_ARG,
                            _("Unsupported scheme in disks URI: %s"),
                            uri->scheme);
+            return -1;
         }
     }