From: Florian Forster <octo@collectd.org>
Date: Fri, 5 Jan 2024 07:03:46 +0000 (+0100)
Subject: cpu plugin: Ensure unpopulated states return NAN.
X-Git-Tag: 6.0.0-rc0~5^2~29
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6597f39c7a6f5c4aa93d75cdf582bf996c588d72;p=thirdparty%2Fcollectd.git

cpu plugin: Ensure unpopulated states return NAN.
---

diff --git a/src/cpu_test.c b/src/cpu_test.c
index 8f400923f..ad46a3621 100644
--- a/src/cpu_test.c
+++ b/src/cpu_test.c
@@ -22,7 +22,7 @@
 #include "cpu.c" /* sic */
 #include "testing.h"
 
-DEF_TEST(usage) {
+DEF_TEST(usage_simple_rate) {
   usage_t usage = {0};
 
   cdtime_t t0 = TIME_T_TO_CDTIME_T(100);
@@ -43,12 +43,20 @@ DEF_TEST(usage) {
 
   EXPECT_EQ_DOUBLE(want_rate, usage_rate(usage, 0, STATE_USER));
 
+  // States that we have not set should be NAN
+  for (state_t s = 0; s < STATE_MAX; s++) {
+    if (s == STATE_USER) {
+      continue;
+    }
+    EXPECT_EQ_DOUBLE(NAN, usage_rate(usage, 0, s));
+  }
+
   usage_reset(&usage);
   return 0;
 }
 
 int main(void) {
-  RUN_TEST(usage);
+  RUN_TEST(usage_simple_rate);
 
   END_TEST;
 }