From: Michael Brown <mcb30@etherboot.org>
Date: Sat, 22 Mar 2008 00:40:33 +0000 (+0000)
Subject: [Settings] Bugfix: store_setting() now applies changes even on root block
X-Git-Tag: v0.9.4~201
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=65c0974d1f52a4a655c069cf65876838f6973ccf;p=thirdparty%2Fipxe.git

[Settings] Bugfix: store_setting() now applies changes even on root block
---

diff --git a/src/core/settings.c b/src/core/settings.c
index eb54ad738..49594dcab 100644
--- a/src/core/settings.c
+++ b/src/core/settings.c
@@ -299,7 +299,6 @@ struct settings * find_settings ( const char *name ) {
  */
 int store_setting ( struct settings *settings, unsigned int tag,
 		    const void *data, size_t len ) {
-	struct settings *parent;
 	int rc;
 
 	/* Sanity check */
@@ -317,8 +316,8 @@ int store_setting ( struct settings *settings, unsigned int tag,
 	/* If these settings are registered, apply potentially-updated
 	 * settings
 	 */
-	for ( parent = settings->parent ; parent ; parent = parent->parent ) {
-		if ( parent == &settings_root ) {
+	for ( ; settings ; settings = settings->parent ) {
+		if ( settings == &settings_root ) {
 			if ( ( rc = apply_settings() ) != 0 )
 				return rc;
 			break;