From: Douglas Bagnall Date: Fri, 12 Apr 2024 06:32:42 +0000 (+1200) Subject: s4:rpc_srv:getncchanges: 4.5 anc emulation uses qsort(), not ldb_qsort() X-Git-Tag: tdb-1.4.11~828 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=65df8ce05c1d1bb9dd93592269ef966446cc5746;p=thirdparty%2Fsamba.git s4:rpc_srv:getncchanges: 4.5 anc emulation uses qsort(), not ldb_qsort() Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett --- diff --git a/source4/rpc_server/drsuapi/getncchanges.c b/source4/rpc_server/drsuapi/getncchanges.c index e33c21200cd..2e95811b447 100644 --- a/source4/rpc_server/drsuapi/getncchanges.c +++ b/source4/rpc_server/drsuapi/getncchanges.c @@ -1026,8 +1026,7 @@ struct drsuapi_changed_objects { sort the objects we send by tree order (Samba 4.5 emulation) */ static int site_res_cmp_anc_order(struct drsuapi_changed_objects *m1, - struct drsuapi_changed_objects *m2, - struct drsuapi_getncchanges_state *getnc_state) + struct drsuapi_changed_objects *m2) { return ldb_dn_compare(m2->dn, m1->dn); } @@ -3322,10 +3321,9 @@ allowed: if (req10->extended_op == DRSUAPI_EXOP_FSMO_RID_ALLOC) { /* Do nothing */ } else if (getnc_state->broken_samba_4_5_get_anc_emulation) { - LDB_TYPESAFE_QSORT(changes, - getnc_state->num_records, - getnc_state, - site_res_cmp_anc_order); + TYPESAFE_QSORT(changes, + getnc_state->num_records, + site_res_cmp_anc_order); } else { LDB_TYPESAFE_QSORT(changes, getnc_state->num_records,