From: Charles <32498151+charlesomer@users.noreply.github.com> Date: Thu, 3 Jun 2021 16:38:33 +0000 (+0100) Subject: Updates to docker build process. X-Git-Tag: 4.1-dev~78^2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=65e66c4845878d7fbf8e19709ae8be60def94022;p=thirdparty%2Fshairport-sync.git Updates to docker build process. --- diff --git a/.github/workflows/docker-build.yaml b/.github/workflows/docker-build.yaml index 772586e1..98a4041e 100644 --- a/.github/workflows/docker-build.yaml +++ b/.github/workflows/docker-build.yaml @@ -39,4 +39,4 @@ jobs: tags: registry.nova.do/shairport-sync:unstable-${{ env.SHAIRPORT_SYNC_BRANCH }} build-args: | SHAIRPORT_SYNC_BRANCH=${{ env.SHAIRPORT_SYNC_BRANCH }} - ssh: github=${{ env.SSH_AUTH_SOCK }} # Can be removed when no longer pulling from private repos. \ No newline at end of file + ssh: default=${{ env.SSH_AUTH_SOCK }} # Can be removed when no longer pulling from private repos. \ No newline at end of file diff --git a/docker/Dockerfile b/docker/Dockerfile index d7df1481..9393f072 100644 --- a/docker/Dockerfile +++ b/docker/Dockerfile @@ -54,7 +54,7 @@ COPY --from=builder-alac /usr/local/include /usr/local/include # TODO: Remove when no longer pulling from private repos. RUN mkdir -p -m 0600 ~/.ssh && ssh-keyscan github.com >> ~/.ssh/known_hosts -RUN --mount=type=ssh,id=github git clone git@github.com:mikebrady/nqptp.git +RUN --mount=type=ssh git clone git@github.com:mikebrady/nqptp.git WORKDIR /nqptp # Use development branch for now. RUN git checkout development diff --git a/docker/README.md b/docker/README.md index 1ea8f984..8172ec08 100644 --- a/docker/README.md +++ b/docker/README.md @@ -6,7 +6,7 @@ Available at: https://hub.docker.com/r/mikebrady/shairport-sync TODO: remove `--ssh` when going public as this is only for private repos. ``` -docker buildx build --ssh github=$SSH_AUTH_SOCK --platform linux/arm/v7 -f ./docker/Dockerfile --build-arg SHAIRPORT_SYNC_BRANCH=unstable-development -t registry.nova.do/shairport-sync:unstable-development . +docker buildx build --ssh github=$SSH_AUTH_SOCK --platform linux/arm/v7 -f ./docker/Dockerfile --build-arg SHAIRPORT_SYNC_BRANCH=development -t registry.nova.do/shairport-sync:unstable-development . ``` `SHAIRPORT_SYNC_BRANCH` is required to ensure the image is built using the expected branch. \ No newline at end of file