From: Thierry Fournier <tfournier@arpalert.org>
Date: Tue, 23 May 2023 16:00:46 +0000 (+0200)
Subject: BUG/MINOR: config: Lenient port configuration parsing
X-Git-Tag: v2.9-dev2~58
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=65f18d65a3822acaa39418d8e919e9afe1f5e781;p=thirdparty%2Fhaproxy.git

BUG/MINOR: config: Lenient port configuration parsing

Configuration parsing allow port like 8000/websocket/. This is
a nonsense and allowing this syntax may hide to the user something
not corresponding to its intent.

This patch should not be backported because it could break existing
configurations
---

diff --git a/src/tools.c b/src/tools.c
index 70ad597a86..7e75e74a8f 100644
--- a/src/tools.c
+++ b/src/tools.c
@@ -1222,6 +1222,8 @@ struct sockaddr_storage *str2sa_range(const char *str, int *port, int *low, int
 		}
 
 		if (isdigit((unsigned char)*port1)) {	/* single port or range */
+			char *endptr;
+
 			port2 = strchr(port1, '-');
 			if (port2) {
 				if (!(opts & PA_O_PORT_RANGE)) {
@@ -1232,8 +1234,16 @@ struct sockaddr_storage *str2sa_range(const char *str, int *port, int *low, int
 			}
 			else
 				port2 = port1;
-			portl = atoi(port1);
-			porth = atoi(port2);
+			portl = strtol(port1, &endptr, 10);
+			if (*endptr != '\0') {
+				memprintf(err, "invalid character '%c' in port number '%s' in '%s'", *endptr, port1, str);
+				goto out;
+			}
+			porth = strtol(port2, &endptr, 10);
+			if (*endptr != '\0') {
+				memprintf(err, "invalid character '%c' in port number '%s' in '%s'", *endptr, port2, str);
+				goto out;
+			}
 
 			if (portl < !!(opts & PA_O_PORT_MAND) || portl > 65535) {
 				memprintf(err, "invalid port '%s'", port1);
@@ -1253,19 +1263,30 @@ struct sockaddr_storage *str2sa_range(const char *str, int *port, int *low, int
 			porta = portl;
 		}
 		else if (*port1 == '-') { /* negative offset */
+			char *endptr;
+
 			if (!(opts & PA_O_PORT_OFS)) {
 				memprintf(err, "port offset not permitted here in '%s'", str);
 				goto out;
 			}
-			portl = atoi(port1 + 1);
+			portl = strtol(port1 + 1, &endptr, 10);
+			if (*endptr != '\0') {
+				memprintf(err, "invalid character '%c' in port number '%s' in '%s'", *endptr, port1 + 1, str);
+				goto out;
+			}
 			porta = -portl;
 		}
 		else if (*port1 == '+') { /* positive offset */
+			char *endptr;
+
 			if (!(opts & PA_O_PORT_OFS)) {
 				memprintf(err, "port offset not permitted here in '%s'", str);
 				goto out;
 			}
-			porth = atoi(port1 + 1);
+			porth = strtol(port1 + 1,  &endptr, 10);
+			if (*endptr != '\0') {
+				memprintf(err, "invalid character '%c' in port number '%s' in '%s'", *endptr, port1 + 1, str);
+				goto out;
 			}
 			porta = porth;
 		}