From: Jeremy Allison <jra@samba.org>
Date: Thu, 23 Apr 2009 09:02:28 +0000 (-0700)
Subject: Fix Coverity bug #902, uninitialized variable.
X-Git-Tag: tdb-1.1.5~919^2~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6610327770f3e7dd3e7a9b71d34b82f1f198a8a4;p=thirdparty%2Fsamba.git

Fix Coverity bug #902, uninitialized variable.
Jeremy.
---

diff --git a/source3/nmbd/nmbd_packets.c b/source3/nmbd/nmbd_packets.c
index f69845b346c..4045184f335 100644
--- a/source3/nmbd/nmbd_packets.c
+++ b/source3/nmbd/nmbd_packets.c
@@ -1936,7 +1936,9 @@ bool send_mailslot(bool unique, const char *mailslot,char *buf, size_t len,
 		DEBUG(0, ("send_mailslot: Cannot write beyond end of packet\n"));
 		return False;
 	} else {
-		memcpy(p2,buf,len);
+		if (len) {
+			memcpy(p2,buf,len);
+		}
 		p2 += len;
 	}
 
diff --git a/source3/nmbd/nmbd_processlogon.c b/source3/nmbd/nmbd_processlogon.c
index 8173337da07..43e80af394d 100644
--- a/source3/nmbd/nmbd_processlogon.c
+++ b/source3/nmbd/nmbd_processlogon.c
@@ -267,7 +267,7 @@ static void nmbd_proxy_logon_done(struct tevent_req *subreq)
 		tevent_req_callback_data(subreq,
 		struct nmbd_proxy_logon_state);
 	NTSTATUS status;
-	DATA_BLOB response;
+	DATA_BLOB response = data_blob_null;
 
 	status = cldap_netlogon_recv(subreq, NULL, state, &state->io);
 	if (!NT_STATUS_IS_OK(status)) {