From: Mike Brady <4265913+mikebrady@users.noreply.github.com>
Date: Thu, 21 Sep 2023 15:34:40 +0000 (+0100)
Subject: Remove redundant (and now faulty) check to see if the player is also principal conn.
X-Git-Tag: 4.3.2^2~44
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=66163c1a71f4db7ddccaffcb59317a325503d97c;p=thirdparty%2Fshairport-sync.git

Remove redundant (and now faulty) check to see if the player is also principal conn.
---

diff --git a/player.c b/player.c
index 3a2fb382..0cfb3554 100644
--- a/player.c
+++ b/player.c
@@ -1778,14 +1778,9 @@ double suggested_volume(rtsp_conn_info *conn) {
 void player_thread_cleanup_handler(void *arg) {
   rtsp_conn_info *conn = (rtsp_conn_info *)arg;
 
-  if ((principal_conn == conn) && (conn != NULL)) {
-    if (config.output->stop) {
-      debug(2, "Connection %d: Stop the output backend.", conn->connection_number);
-      config.output->stop();
-    }
-  } else {
-    if (conn != NULL)
-      debug(1, "Connection %d: this conn is not the principal_conn.", conn->connection_number);
+  if (config.output->stop) {
+    debug(1, "Connection %d: Stop the output backend.", conn->connection_number);
+    config.output->stop();
   }
 
   int oldState;