From: Ondrej Zajicek <santiago@crfreenet.org>
Date: Fri, 21 Nov 2008 12:05:12 +0000 (+0100)
Subject: I am not sure whether this is proper fix for a problem that birdc
X-Git-Tag: v1.2.0~170
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=661ec5db7fa047d883997d0b2cbdd71659f80777;p=thirdparty%2Fbird.git

I am not sure whether this is proper fix for a problem that birdc
shows only parts of larger outputs (for example 'show route all').
It seems that birdc reads (from bird) and writes (to stdout)
everything but during execution of some readline code some already
written output disappeared (although it is fflush()ed and
tcdrain()ed).

As birdc reads from stdin when select said there are some data,
O_NONBLOCK for stdin is unnecessary and when it is removed,
i didn't notified this problem.
---

diff --git a/client/client.c b/client/client.c
index 905526a47..ce9bdb64e 100644
--- a/client/client.c
+++ b/client/client.c
@@ -201,8 +201,9 @@ input_init(void)
   rl_add_defun("bird-help", input_help, '?');
   rl_callback_handler_install("bird> ", got_line);
   input_initialized = 1;
-  if (fcntl(0, F_SETFL, O_NONBLOCK) < 0)
-    die("fcntl: %m");
+//  readline library does strange things when stdin is nonblocking.
+//  if (fcntl(0, F_SETFL, O_NONBLOCK) < 0)
+//    die("fcntl: %m");
 }
 
 static void