From: Victor Julien <vjulien@oisf.net>
Date: Tue, 9 Jan 2024 15:10:30 +0000 (+0100)
Subject: detect/threshold: minor cleanup
X-Git-Tag: suricata-8.0.0-beta1~1094
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6622dc7444b604ccbbc7ba8a1331ef04a4a14e9d;p=thirdparty%2Fsuricata.git

detect/threshold: minor cleanup
---

diff --git a/src/detect-engine-threshold.c b/src/detect-engine-threshold.c
index 3f7005de7b..2203308288 100644
--- a/src/detect-engine-threshold.c
+++ b/src/detect-engine-threshold.c
@@ -982,19 +982,18 @@ void ThresholdHashInit(DetectEngineCtx *de_ctx)
  */
 void ThresholdHashAllocate(DetectEngineCtx *de_ctx)
 {
-    Signature *s = de_ctx->sig_list;
+    const Signature *s = de_ctx->sig_list;
     bool has_by_rule_tracking = false;
-    const DetectThresholdData *td = NULL;
-    const SigMatchData *smd;
 
     /* Find the signature with the highest signature number that is using
        thresholding with by_rule tracking. */
     uint32_t highest_signum = 0;
     while (s != NULL) {
         if (s->sm_arrays[DETECT_SM_LIST_SUPPRESS] != NULL) {
-            smd = NULL;
+            const SigMatchData *smd = NULL;
             do {
-                td = SigGetThresholdTypeIter(s, &smd, DETECT_SM_LIST_SUPPRESS);
+                const DetectThresholdData *td =
+                        SigGetThresholdTypeIter(s, &smd, DETECT_SM_LIST_SUPPRESS);
                 if (td == NULL) {
                     continue;
                 }
@@ -1009,9 +1008,10 @@ void ThresholdHashAllocate(DetectEngineCtx *de_ctx)
         }
 
         if (s->sm_arrays[DETECT_SM_LIST_THRESHOLD] != NULL) {
-            smd = NULL;
+            const SigMatchData *smd = NULL;
             do {
-                td = SigGetThresholdTypeIter(s, &smd, DETECT_SM_LIST_THRESHOLD);
+                const DetectThresholdData *td =
+                        SigGetThresholdTypeIter(s, &smd, DETECT_SM_LIST_THRESHOLD);
                 if (td == NULL) {
                     continue;
                 }