From: Mark Andrews <marka@isc.org>
Date: Mon, 19 Nov 2018 01:27:56 +0000 (+1100)
Subject: address resource leak; don't call close() on socket error;
X-Git-Tag: v9.13.5~36^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6696a40ea97df87bff520e23f38c65bde63237b0;p=thirdparty%2Fbind9.git

address resource leak; don't call close() on socket error;
---

diff --git a/lib/isc/unix/socket.c b/lib/isc/unix/socket.c
index ff9efe535c7..7e1c616afdb 100644
--- a/lib/isc/unix/socket.c
+++ b/lib/isc/unix/socket.c
@@ -5453,7 +5453,6 @@ init_hasreuseport() {
 	int sock, yes = 1;
 	sock = socket(AF_INET, SOCK_DGRAM, 0);
 	if (sock < 0) {
-		close(sock);
 		return;
 	} else if (setsockopt(sock, SOL_SOCKET, SO_REUSEADDR,
 			      (void *)&yes, sizeof(yes)) < 0)
@@ -5467,6 +5466,7 @@ init_hasreuseport() {
 		return;
 	}
 	hasreuseport = true;
+	close(sock);
 #endif
 }