From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Thu, 13 Jul 2017 13:20:53 +0000 (+0300)
Subject: lib-storage: mailbox_create_missing_dir() - Fix handling NULL mailbox directory
X-Git-Tag: 2.3.0.rc1~1260
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=66a4847c67f7fe2f076b7c11103ae045fa218bec;p=thirdparty%2Fdovecot%2Fcore.git

lib-storage: mailbox_create_missing_dir() - Fix handling NULL mailbox directory

It would have caused stat(NULL), which would have failed.
Broken by 7071a02a8413fb409ade1625f6a1763c7493b66b
---

diff --git a/src/lib-storage/mail-storage.c b/src/lib-storage/mail-storage.c
index 75d9259126..fb20e35249 100644
--- a/src/lib-storage/mail-storage.c
+++ b/src/lib-storage/mail-storage.c
@@ -2732,7 +2732,7 @@ int mailbox_create_missing_dir(struct mailbox *box,
 	if (stat(dir, &st) == 0)
 		return 0;
 
-	if (null_strcmp(dir, mail_dir) != 0 &&
+	if (null_strcmp(dir, mail_dir) != 0 && mail_dir != NULL &&
 	    stat(mail_dir, &st) < 0 && (errno == ENOENT || errno == ENOTDIR)) {
 		/* Race condition - mail root directory doesn't exist
 		   anymore either. We shouldn't create this directory