From: Dan Carpenter Date: Thu, 15 Aug 2024 11:25:08 +0000 (+0300) Subject: ata: ahci_imx: Fix error code in probe() X-Git-Tag: v6.12-rc1~127^2~17 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=66afec7c6992a04f8ab65b54421bdb5f8ac806e6;p=thirdparty%2Fkernel%2Flinux.git ata: ahci_imx: Fix error code in probe() Return a negative error code if devm_clk_get() fails. Don't return success. Fixes: 3156e1b2c071 ("ata: ahci_imx: AHB clock rate setting is not required on i.MX8QM AHCI SATA") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/cbcbdfc2-ddc7-4684-8ad4-018227823546@stanley.mountain Signed-off-by: Niklas Cassel --- diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c index 65f98e8fdf07b..6f955e9105e88 100644 --- a/drivers/ata/ahci_imx.c +++ b/drivers/ata/ahci_imx.c @@ -963,6 +963,7 @@ static int imx_ahci_probe(struct platform_device *pdev) imxpriv->ahb_clk = devm_clk_get(dev, "ahb"); if (IS_ERR(imxpriv->ahb_clk)) { dev_err(dev, "Failed to get ahb clock\n"); + ret = PTR_ERR(imxpriv->ahb_clk); goto disable_sata; } reg_val = clk_get_rate(imxpriv->ahb_clk) / 1000;