From: Pauli <pauli@openssl.org>
Date: Fri, 1 Apr 2022 01:18:44 +0000 (+1100)
Subject: Fix Coverity 1503329 use after free
X-Git-Tag: openssl-3.2.0-alpha1~2695
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=66cb4fcdc5039fe5b1476ed48a936137a307a58b;p=thirdparty%2Fopenssl.git

Fix Coverity 1503329 use after free

Another false positive tagged as such

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/18014)
---

diff --git a/crypto/store/store_lib.c b/crypto/store/store_lib.c
index 696056e370b..3d91f159b69 100644
--- a/crypto/store/store_lib.c
+++ b/crypto/store/store_lib.c
@@ -215,6 +215,8 @@ OSSL_STORE_open_ex(const char *uri, OSSL_LIB_CTX *libctx, const char *propq,
          */
         (void)ossl_store_close_it(&tmpctx);
     }
+    /* Coverity false positive, the reference counting is confusing it */
+    /* coverity[pass_freed_arg] */
     OSSL_STORE_LOADER_free(fetched_loader);
     OPENSSL_free(propq_copy);
     OPENSSL_free(ctx);