From: Arthur Gautier <baloo@gandi.net>
Date: Wed, 30 Mar 2016 23:09:45 +0000 (+0000)
Subject: test: incorrect test relying on type comparison
X-Git-Tag: v1.13.0~7^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=670ec06fb389c6e8ff64aee2c0ddf538483efb90;p=thirdparty%2Fdnspython.git

test: incorrect test relying on type comparison

This test relies on python2 type comparison mechanism.

A simplier test case is:
``` python
In [1]: class X(object):
    def __gt__(self, other):
        return NotImplemented
   ...:

In [2]: a=X()

In [3]: a>1
Out[3]: True

In [4]: a<1
Out[4]: False
```

Works on python2, not on python3.
Therefore, I'm dropping the testcase

See http://eli.thegreenplace.net/2016/comparing-types-in-python-3/ for
more information about that

Signed-off-by: Arthur Gautier <baloo@gandi.net>
---

diff --git a/tests/test_name.py b/tests/test_name.py
index 4935564d..f8e3d23a 100644
--- a/tests/test_name.py
+++ b/tests/test_name.py
@@ -158,9 +158,6 @@ class NameTestCase(unittest.TestCase):
     def testCompare4(self):
         self.failUnless(dns.name.root != 1)
 
-    def testCompare5(self):
-        self.failUnless(dns.name.root < 1 or dns.name.root > 1)
-
     def testSubdomain1(self):
         self.failUnless(not dns.name.empty.is_subdomain(dns.name.root))