From: Jan Doskočil <jan.doskocil@nic.cz>
Date: Tue, 26 Nov 2024 11:25:33 +0000 (+0100)
Subject: knot-exporter: no zone timers by default
X-Git-Tag: v3.5.0~202^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=672967638cfc31ea90305ccf7298317495a02689;p=thirdparty%2Fknot-dns.git

knot-exporter: no zone timers by default
---

diff --git a/python/knot_exporter/knot_exporter/knot_exporter.py b/python/knot_exporter/knot_exporter/knot_exporter.py
index 8135294b41..7d6fc37919 100755
--- a/python/knot_exporter/knot_exporter/knot_exporter.py
+++ b/python/knot_exporter/knot_exporter/knot_exporter.py
@@ -216,15 +216,23 @@ def main():
     )
 
     parser.add_argument(
-        "--no-zone-timers",
+        "--no-zone-serial",
         action='store_false',
-        help="disable collection of zone timer settings"
+        help="disable collection of zone serial"
     )
 
     parser.add_argument(
-        "--no-zone-serial",
-        action='store_false',
-        help="disable collection of zone serial"
+        "--zone-timers",
+        action='store_true',
+        default=False,
+        help="enable collection of zone SOA timer values"
+    )
+
+    parser.add_argument(
+        "--no-zone-timers",
+        action='store_const',
+        help="supported for compatibility reasons; no effect",
+        # deprecated=True # in python >=3.13
     )
 
     args = parser.parse_args()
@@ -237,7 +245,7 @@ def main():
         args.no_global_stats,
         args.no_zone_stats,
         args.no_zone_status,
-        args.no_zone_timers,
+        args.zone_timers,
         args.no_zone_serial,
     ))