From: Volker Lendecke <vl@samba.org>
Date: Tue, 4 Aug 2026 14:07:50 +0000 (+0200)
Subject: smbd: Fix an error path memleak
X-Git-Tag: samba-4.25.0rc1~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=672ffef43b9fc6209fe7f45c25964d00b8d3f0df;p=thirdparty%2Fsamba.git

smbd: Fix an error path memleak

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source3/smbd/smb1_negprot.c b/source3/smbd/smb1_negprot.c
index 3e02c30d8b0..db96b3ffceb 100644
--- a/source3/smbd/smb1_negprot.c
+++ b/source3/smbd/smb1_negprot.c
@@ -325,12 +325,12 @@ static NTSTATUS reply_nt1(struct smb_request *req, uint16_t choice)
 		}
 
 		ret = message_push_blob(&req->outbuf, spnego_blob);
+		data_blob_free(&spnego_blob);
 		if (ret == -1) {
 			DEBUG(0, ("Could not push spnego blob\n"));
 			reply_nterror(req, NT_STATUS_NO_MEMORY);
 			return NT_STATUS_NO_MEMORY;
 		}
-		data_blob_free(&spnego_blob);
 
 		SCVAL(req->outbuf,smb_vwv16+1, 0);
 		DEBUG(3,("using SPNEGO\n"));