From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 26 Mar 2020 12:31:05 +0000 (+0100)
Subject: qemuBlockJobRefreshJobs: Warn readers that 'job' may be invalid after update
X-Git-Tag: v6.3.0-rc1~274
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6746136a2763471aef94681200580ed310add81d;p=thirdparty%2Flibvirt.git

qemuBlockJobRefreshJobs: Warn readers that 'job' may be invalid after update

Add a comment noting that job update can cause the pointer to be invalid
and thus should not be accessed after.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Mores <pmores@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
index 6576f8721f..2032c0c1c5 100644
--- a/src/qemu/qemu_blockjob.c
+++ b/src/qemu/qemu_blockjob.c
@@ -571,6 +571,7 @@ qemuBlockJobRefreshJobs(virQEMUDriverPtr driver,
 
         if (job->newstate != -1)
             qemuBlockJobUpdate(vm, job, QEMU_ASYNC_JOB_NONE);
+        /* 'job' may be invalid after this update */
     }
 
     /* remove data for job which qemu didn't report (the algorithm is