From: Aki Tuomi <aki.tuomi@open-xchange.com>
Date: Tue, 31 Jan 2023 11:51:36 +0000 (+0200)
Subject: stats: Populate group_by field earlier in settings check
X-Git-Tag: 2.4.0~2918
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=675eb062baadb902d7133bf4b706cbf379582ec3;p=thirdparty%2Fdovecot%2Fcore.git

stats: Populate group_by field earlier in settings check

This is needed in next commit to avoid crash.
---

diff --git a/src/stats/stats-settings.c b/src/stats/stats-settings.c
index 4ca9abfe37..78402d0780 100644
--- a/src/stats/stats-settings.c
+++ b/src/stats/stats-settings.c
@@ -459,6 +459,7 @@ static bool parse_metric_group_by(struct stats_metric_settings *set,
 
 		/* <field name>:<aggregation func>... */
 		params = t_strsplit(*tmp, ":");
+		group_by.field = p_strdup(pool, params[0]);
 
 		if (params[1] == NULL) {
 			/* <field name> - alias for <field>:discrete */
@@ -485,8 +486,6 @@ static bool parse_metric_group_by(struct stats_metric_settings *set,
 			return FALSE;
 		}
 
-		group_by.field = p_strdup(pool, params[0]);
-
 		array_push_back(&set->parsed_group_by, &group_by);
 	}