From: Pieter Lexis <pieter.lexis@powerdns.com>
Date: Wed, 13 Feb 2019 16:06:04 +0000 (+0100)
Subject: SuffixMatchTree: add comment on value replacement
X-Git-Tag: rec-4.2.0-beta1~7^2~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=67689ec72ed56b7add16f9c534992155afcbf08f;p=thirdparty%2Fpdns.git

SuffixMatchTree: add comment on value replacement
---

diff --git a/pdns/dnsname.hh b/pdns/dnsname.hh
index 5c2b6bf016..cb69cac88a 100644
--- a/pdns/dnsname.hh
+++ b/pdns/dnsname.hh
@@ -308,6 +308,9 @@ struct SuffixMatchTree
     if (labels.empty()) {
       // The child is no longer an endnode
       child->endNode = false;
+      // TODO clear d_value for this node as d_value = T() would break for types
+      // that require initialization
+
       // If the child has no further children, just remove it from the set.
       if (child->children.empty()) {
         children.erase(child);