From: Miod Vallat <miod.vallat@powerdns.com>
Date: Fri, 12 Dec 2025 13:22:01 +0000 (+0100)
Subject: Address Coverity reported unnecessary object copies.
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6788af3df862c18b0d086474b250346caa759de5;p=thirdparty%2Fpdns.git

Address Coverity reported unnecessary object copies.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---

diff --git a/modules/geoipbackend/geoipbackend.cc b/modules/geoipbackend/geoipbackend.cc
index 0c4f90027f..998b12ec56 100644
--- a/modules/geoipbackend/geoipbackend.cc
+++ b/modules/geoipbackend/geoipbackend.cc
@@ -302,7 +302,7 @@ bool GeoIPBackend::loadDomain(const std::string& origin, const YAML::Node& domai
           rr.weight = 100;
         }
         rr.auth = true;
-        rrs.push_back(rr);
+        rrs.push_back(std::move(rr));
       }
       std::swap(dom.records[qname.operator const DNSName&()], rrs);
     }
diff --git a/pdns/auth-secondarycommunicator.cc b/pdns/auth-secondarycommunicator.cc
index eb17c85508..b0153eb5bb 100644
--- a/pdns/auth-secondarycommunicator.cc
+++ b/pdns/auth-secondarycommunicator.cc
@@ -412,7 +412,7 @@ static bool catalogProcess(const XFRContext& ctx, vector<DNSResourceRecord>& rrs
           if (content.length() >= 2 && content.at(0) == '\"' && content.at(content.length() - 1) == '\"') { // TXT pain
             content = content.substr(1, content.length() - 2);
           }
-          ci.d_group.insert(content);
+          ci.d_group.insert(std::move(content));
         }
       }
     }
@@ -556,7 +556,7 @@ static bool processRecordForZS(const DNSName& domain, bool& firstNSEC3, DNSResou
     ctx.optOutFlag = static_cast<bool>(ns3rc.d_flags & 1);
     if (ns3rc.isSet(QType::NS) && !(rr.qname == domain)) {
       DNSName hashPart = rr.qname.makeRelative(domain);
-      ctx.secured.insert(hashPart);
+      ctx.secured.insert(std::move(hashPart));
     }
     return false;
   }