From: Amos Jeffries <squid3@treenet.co.nz>
Date: Sat, 17 Jan 2009 02:03:18 +0000 (+1300)
Subject: NTLM_AUTH/SMB_LM: replace assertion with clean error report
X-Git-Tag: SQUID_3_0_STABLE12~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=67a5614c70311258ad3c97cc752ed72fce2d949c;p=thirdparty%2Fsquid.git

NTLM_AUTH/SMB_LM: replace assertion with clean error report
---

diff --git a/helpers/ntlm_auth/SMB/ntlm_auth.c b/helpers/ntlm_auth/SMB/ntlm_auth.c
index aedfc240fb..d4013ae6e8 100644
--- a/helpers/ntlm_auth/SMB/ntlm_auth.c
+++ b/helpers/ntlm_auth/SMB/ntlm_auth.c
@@ -317,8 +317,7 @@ manage_request()
 	    return;
 	    /* notreached */
 	case NTLM_CHALLENGE:
-	    SEND
-		("NA Got a challenge. We refuse to have our authority disputed");
+	    SEND("NA Got a challenge. We refuse to have our authority disputed");
 	    return;
 	    /* notreached */
 	case NTLM_AUTHENTICATE:
@@ -416,8 +415,10 @@ manage_request()
 			(ntlm_authenticate *) decoded, plen);
 		    return;
 		}
+                SEND("BH unknown internal error.");
+                return;
 	    }
-            assert(cred != NULL);
+
 	    lc(cred);		/* let's lowercase them for our convenience */
 	    SEND2("AF %s", cred);
 	    return;