From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Thu, 27 Nov 2025 09:24:53 +0000 (+0100)
Subject: dnsdist: Stop using `random()` to bench rules
X-Git-Tag: rec-5.4.0-alpha1~50^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=67ab59480b02e288fc455ec0aa6c5037dff43ef5;p=thirdparty%2Fpdns.git

dnsdist: Stop using `random()` to bench rules

This makes Coverity (CID 500050) and probably other tools
very unhappy.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
---

diff --git a/pdns/dnsdistdist/dnsdist-lua-rules.cc b/pdns/dnsdistdist/dnsdist-lua-rules.cc
index 0643311575..e915f817aa 100644
--- a/pdns/dnsdistdist/dnsdist-lua-rules.cc
+++ b/pdns/dnsdistdist/dnsdist-lua-rules.cc
@@ -522,7 +522,7 @@ void setupLuaRuleChainsManagement(LuaContext& luaCtx)
       entry.ids.qclass = QClass::IN;
       entry.ids.protocol = dnsdist::Protocol::DoUDP;
       entry.ids.origRemote = ComboAddress("127.0.0.1");
-      entry.ids.origRemote.sin4.sin_addr.s_addr = random();
+      entry.ids.origRemote.sin4.sin_addr.s_addr = dns_random_uint32();
       entry.ids.queryRealTime.start();
       GenericDNSPacketWriter<PacketBuffer> writer(entry.packet, entry.ids.qname, entry.ids.qtype);
       items.push_back(std::move(entry));