From: Volker Lendecke <vl@samba.org>
Date: Sun, 31 Aug 2008 10:15:35 +0000 (+0200)
Subject: Fix Coverity ID 589, dead code
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=67c0835226e189deba5856710a1dea19ac5f30fd;p=thirdparty%2Fsamba.git

Fix Coverity ID 589, dead code
---

diff --git a/source/nsswitch/libwbclient/wbc_sid.c b/source/nsswitch/libwbclient/wbc_sid.c
index 324a19bd564..f4ffa4e5caa 100644
--- a/source/nsswitch/libwbclient/wbc_sid.c
+++ b/source/nsswitch/libwbclient/wbc_sid.c
@@ -294,9 +294,18 @@ wbcErr wbcLookupSid(const struct wbcDomainSid *sid,
 		}
 	}
 	else {
+#if 0
+		/*
+		 * Found by Coverity: In this particular routine we can't end
+		 * up here with a non-NULL name. Further up there are just two
+		 * exit paths that lead here, neither of which leave an
+		 * allocated name. If you add more paths up there, re-activate
+		 * this.
+		 */
 		if (name != NULL) {
 			talloc_free(name);
 		}
+#endif
 		if (domain != NULL) {
 			talloc_free(domain);
 		}