From: Boris Fiuczynski Date: Mon, 4 Apr 2022 18:22:37 +0000 (+0200) Subject: tests: Fixing compiler warning in cputest X-Git-Tag: v8.3.0-rc1~172 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=67c77744d74fe99a6b0e4ddef6869b305e29d6aa;p=thirdparty%2Flibvirt.git tests: Fixing compiler warning in cputest Found when building on Fedora 36 on s390x. C compiler for the host machine: gcc (gcc 12.0.1 "gcc (GCC) 12.0.1 20220308 (Red Hat 12.0.1-0)") C linker for the host machine: gcc ld.bfd 2.37-24 In function ‘cpuTestUpdateLiveCompare’, inlined from ‘cpuTestUpdateLive’ at ../dist-unpack/libvirt-8.2.5/tests/cputest.c:784:12: ../dist-unpack/libvirt-8.2.5/tests/cputest.c:696:21: warning: potential null pointer dereference [-Wnull-dereference] 696 | featAct->policy == VIR_CPU_FEATURE_REQUIRE) || | ~~~~~~~^~~~~~~~ Signed-off-by: Boris Fiuczynski Reviewed-by: Michal Privoznik --- diff --git a/tests/cputest.c b/tests/cputest.c index 609b5df7c6..95fb37d15c 100644 --- a/tests/cputest.c +++ b/tests/cputest.c @@ -692,7 +692,7 @@ cpuTestUpdateLiveCompare(virArch arch, if ((cmp == 0 && featAct->policy == VIR_CPU_FEATURE_REQUIRE && featExp->policy == VIR_CPU_FEATURE_DISABLE) || - (cmp < 0 && + (cmp < 0 && featAct && featAct->policy == VIR_CPU_FEATURE_REQUIRE) || (cmp > 0 && featExp->policy == VIR_CPU_FEATURE_DISABLE)) {