From: mkanat%bugzilla.org <>
Date: Thu, 21 Aug 2008 04:34:50 +0000 (+0000)
Subject: Bug 451449: "Can't use undefined value as ARRAY reference" when logging into a new... 
X-Git-Tag: bugzilla-3.3.1~213
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=67c886dd7eccb7f3136bb4f433db00905140baa3;p=thirdparty%2Fbugzilla.git

Bug 451449: "Can't use undefined value as ARRAY reference" when logging into a new account
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit
---

diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm
index 7607232797..ccee85755b 100644
--- a/Bugzilla/User.pm
+++ b/Bugzilla/User.pm
@@ -445,15 +445,15 @@ sub bless_groups {
                        AND groups.id=user_group_map.group_id)
                      OR (groups.id = ggm.grantor_id
                          AND ggm.grant_type = ' . GROUP_BLESS . '
-                         AND ggm.member_id ' . $dbh->sql_in(\@group_ids)
+                         AND ' . $dbh->sql_in('ggm.member_id', \@group_ids)
                      . ') )';
 
     # If visibilitygroups are used, restrict the set of groups.
     if (Bugzilla->params->{'usevisibilitygroups'}) {
         return [] if !$self->visible_groups_as_string;
         # Users need to see a group in order to bless it.
-        $query .= " AND groups.id "
-                  . $dbh->sql_in($self->visible_groups_inherited);
+        $query .= " AND "
+            . $dbh->sql_in('groups.id', $self->visible_groups_inherited);
     }
 
     my $ids = $dbh->selectcol_arrayref($query, undef, $self->id);