From: Alan T. DeKok <aland@freeradius.org>
Date: Sun, 17 May 2020 22:05:57 +0000 (-0400)
Subject: out-smart clan scan
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=67d2fbedd9751937a88cb3cfb3a49ce747e2d534;p=thirdparty%2Ffreeradius-server.git

out-smart clan scan
---

diff --git a/src/modules/proto_control/radmin.c b/src/modules/proto_control/radmin.c
index 23ccc451fa1..4417364b198 100644
--- a/src/modules/proto_control/radmin.c
+++ b/src/modules/proto_control/radmin.c
@@ -133,7 +133,7 @@ typedef struct {
 //static radmin_state_t state;
 
 static bool echo = false;
-static char const *secret = NULL;
+static char const *secret = "";
 static bool unbuffered = false;
 static bool use_readline = true;
 
@@ -219,10 +219,6 @@ static ssize_t do_challenge(int fd)
 	fr_conduit_type_t conduit;
 	uint8_t challenge[16];
 
-#ifdef __clang_analyzer__
-	if (!secret) return -1;
-#endif
-
 	challenge[0] = 0x00;
 
 	/*
@@ -880,6 +876,7 @@ int main(int argc, char **argv)
 	}
 
 	fr_debug_lvl = L_DBG_LVL_1;
+	secret = NULL;
 
 	while ((c = getopt(argc, argv, "d:D:hi:e:Ef:n:qs:S:x")) != -1) switch (c) {
 		case 'd':