From: Michael Brown <mcb30@ipxe.org>
Date: Thu, 11 Nov 2010 01:14:05 +0000 (+0000)
Subject: [tcp] Set PSH flag only on packets containing data
X-Git-Tag: v1.20.1~2437
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=67dc832d152bbbaa6c3046eb68e876d2527beb9a;p=thirdparty%2Fipxe.git

[tcp] Set PSH flag only on packets containing data

Suggested-by: Yelena Kadach <klenusik@hotmail.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
---

diff --git a/src/net/tcp.c b/src/net/tcp.c
index 420640346..c31047712 100644
--- a/src/net/tcp.c
+++ b/src/net/tcp.c
@@ -522,7 +522,7 @@ static int tcp_xmit ( struct tcp_connection *tcp ) {
 		tsopt->tsopt.tsval = htonl ( currticks() );
 		tsopt->tsopt.tsecr = htonl ( tcp->ts_recent );
 	}
-	if ( ! ( flags & TCP_SYN ) )
+	if ( len != 0 )
 		flags |= TCP_PSH;
 	tcphdr = iob_push ( iobuf, sizeof ( *tcphdr ) );
 	memset ( tcphdr, 0, sizeof ( *tcphdr ) );