From: Mateusz Guzik Date: Mon, 27 Jan 2025 20:54:04 +0000 (+0100) Subject: apparmor: use the condition in AA_BUG_FMT even with debug disabled X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=67e370aa7f968f6a4f3573ed61a77b36d1b26475;p=thirdparty%2Fkernel%2Flinux.git apparmor: use the condition in AA_BUG_FMT even with debug disabled This follows the established practice and fixes a build failure for me: security/apparmor/file.c: In function ‘__file_sock_perm’: security/apparmor/file.c:544:24: error: unused variable ‘sock’ [-Werror=unused-variable] 544 | struct socket *sock = (struct socket *) file->private_data; | ^~~~ Signed-off-by: Mateusz Guzik Signed-off-by: John Johansen --- diff --git a/security/apparmor/include/lib.h b/security/apparmor/include/lib.h index 256f4577c6535..d947998262b26 100644 --- a/security/apparmor/include/lib.h +++ b/security/apparmor/include/lib.h @@ -60,7 +60,11 @@ do { \ #define AA_BUG_FMT(X, fmt, args...) \ WARN((X), "AppArmor WARN %s: (" #X "): " fmt, __func__, ##args) #else -#define AA_BUG_FMT(X, fmt, args...) no_printk(fmt, ##args) +#define AA_BUG_FMT(X, fmt, args...) \ + do { \ + BUILD_BUG_ON_INVALID(X); \ + no_printk(fmt, ##args); \ + } while (0) #endif int aa_parse_debug_params(const char *str);