From: Victor Julien <vjulien@oisf.net>
Date: Fri, 17 Mar 2023 14:46:00 +0000 (+0100)
Subject: detect/pkt_data: remove obsolete tests
X-Git-Tag: suricata-7.0.0-rc2~405
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=67ef4b15bb48f8bbe0ded11b30426f7e7ce89a2c;p=thirdparty%2Fsuricata.git

detect/pkt_data: remove obsolete tests
---

diff --git a/src/detect-pkt-data.c b/src/detect-pkt-data.c
index 4b20b31a62..80673979ad 100644
--- a/src/detect-pkt-data.c
+++ b/src/detect-pkt-data.c
@@ -85,33 +85,6 @@ static int DetectPktDataSetup (DetectEngineCtx *de_ctx, Signature *s, const char
 #ifdef UNITTESTS
 
 /************************************Unittests*********************************/
-static int g_file_data_buffer_id = 0;
-
-static int DetectPktDataTest01(void)
-{
-    DetectEngineCtx *de_ctx = DetectEngineCtxInit();
-    FAIL_IF_NULL(de_ctx);
-    de_ctx->flags |= DE_QUIET;
-
-    Signature *sig = DetectEngineAppendSig(de_ctx, "alert tcp any any -> any any "
-                               "(file_data; content:\"in file data\";"
-                               " pkt_data; content:\"in pkt data\"; sid:1;)");
-    FAIL_IF_NULL(sig);
-
-    SigMatch *sm = de_ctx->sig_list->sm_lists[g_file_data_buffer_id];
-    FAIL_IF_NULL(sm);
-
-    sm = de_ctx->sig_list->sm_lists[DETECT_SM_LIST_PMATCH];
-    FAIL_IF_NULL(sm);
-
-    FAIL_IF_NOT(sm->type == DETECT_CONTENT);
-    FAIL_IF_NOT_NULL(sm->next);
-
-    FAIL_IF_NOT(sig->init_data->list == DETECT_SM_LIST_NOTSET);
-    DetectEngineCtxFree(de_ctx);
-    PASS;
-}
-
 static int DetectPktDataTest02(void)
 {
     DetectEngineCtx *de_ctx = DetectEngineCtxInit();
@@ -128,8 +101,6 @@ static int DetectPktDataTest02(void)
 
 static void DetectPktDataTestRegister(void)
 {
-    g_file_data_buffer_id = DetectBufferTypeGetByName("file_data");
-    UtRegisterTest("DetectPktDataTest01", DetectPktDataTest01);
     UtRegisterTest("DetectPktDataTest02", DetectPktDataTest02);
 }
 #endif