From: Amitay Isaacs <amitay@gmail.com>
Date: Wed, 6 Jun 2018 13:47:13 +0000 (+0200)
Subject: ctdb-daemon: Avoid memory leak when packet is deferred
X-Git-Tag: talloc-2.3.1~239
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=680df07630a94b3e76edefe98ee0986e7e5e1f12;p=thirdparty%2Fsamba.git

ctdb-daemon: Avoid memory leak when packet is deferred

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
---

diff --git a/ctdb/server/ctdb_server.c b/ctdb/server/ctdb_server.c
index 9724d1fe0a8..0d5451d62a8 100644
--- a/ctdb/server/ctdb_server.c
+++ b/ctdb/server/ctdb_server.c
@@ -375,8 +375,9 @@ static void ctdb_defer_packet(struct ctdb_context *ctdb, struct ctdb_req_header
 		return;
 	}
 	q->ctdb = ctdb;
-	q->hdr = talloc_memdup(ctdb, hdr, hdr->length);
+	q->hdr = talloc_memdup(q, hdr, hdr->length);
 	if (q->hdr == NULL) {
+		talloc_free(q);
 		DEBUG(DEBUG_ERR,("Error copying deferred packet to self\n"));
 		return;
 	}